self-checkout: make barcode always uppercase #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
force-pushed
the
fix/self-checkout
branch
from
1314087 to
324e0e7
Compare
ntarocco
commented
Oct 16, 2024
| onChange={(e) => this.setState({ manualBarcode: e.target.value })} | ||
| value={manualBarcode} | ||
| onChange={(e) => | ||
| this.setState({ manualBarcode: e.target.value?.toUpperCase() }) |
There was a problem hiding this comment.
Automatic uppercase on typing
ntarocco
commented
Oct 16, 2024
| /> | ||
| <Button | ||
| onClick={() => onChange(manualBarcode)} | ||
| onClick={() => manualBarcode && onBarcodeInput(manualBarcode)} | ||
| disabled={!manualBarcode} |
There was a problem hiding this comment.
Disable the btn if no barcode inserted
ntarocco
commented
Oct 16, 2024
| const response = await itemApi.list(itemApi.query().withBarcode(term).qs()); | ||
| const upperCasedTerm = term.toUpperCase(); | ||
| const response = await itemApi.list( | ||
| itemApi.query().withBarcode(upperCasedTerm).qs() |
There was a problem hiding this comment.
should not be needed, but just in case....
kpsherva
approved these changes
Oct 17, 2024
ntarocco
force-pushed
the
fix/self-checkout
branch
from
324e0e7 to
0e3d9f8
Compare
ntarocco
force-pushed
the
master
branch
2 times, most recently
from
9426505 to
014ef04
Compare
ntarocco
force-pushed
the
fix/self-checkout
branch
from
0e3d9f8 to
bb7dec0
Compare
sakshamarora1
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.